Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser][MT] hybrid globalization #98483

Closed
3 of 4 tasks
pavelsavara opened this issue Feb 15, 2024 · 2 comments
Closed
3 of 4 tasks

[browser][MT] hybrid globalization #98483

pavelsavara opened this issue Feb 15, 2024 · 2 comments
Assignees
Labels
arch-wasm WebAssembly architecture area-VM-threading-mono in-pr There is an active PR which will close this issue when it is merged os-browser Browser variant of arch-wasm
Milestone

Comments

@pavelsavara
Copy link
Member

pavelsavara commented Feb 15, 2024

plan A)

  • make hybrid globalization not supported with MT
  • tree-shake hybrid JS code via rollup WasmEnableThreads conditional compilation
  • ideally move the code to sub-folder
  • also conditonal ICALs in corebindings.c
  • switch off HG tests with MT

plan B) - applied

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm labels Feb 15, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Feb 15, 2024
@ghost
Copy link

ghost commented Feb 15, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

plan A)

  • make hybrid globalization not supported with MT
  • tree-shake hybrid JS code via rollup WasmEnableThreads conditional compilation
  • ideally move the code to sub-folder
  • also conditonal ICALs in corebindings.c

plan B)

  • reduce usage of mono_wasm_new_external_root, wrap_error_root, wrap_no_error_root and stringToMonoStringRoot from hybrid
  • because they interact with GC, which could lead to deadlock on UI thread.
Author: pavelsavara
Assignees: ilonatommy
Labels:

arch-wasm, area-VM-threading-mono, os-browser

Milestone: 9.0.0

@ilonatommy
Copy link
Member

Closing as not planned after #110567

@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-VM-threading-mono in-pr There is an active PR which will close this issue when it is merged os-browser Browser variant of arch-wasm
Projects
None yet
3 participants