-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] Remove WASM HybridGlobalization
from runtime code
#110567
[browser] Remove WASM HybridGlobalization
from runtime code
#110567
Conversation
We finish with
Edit: |
WBT tests will fail until dotnet/icu#536 flows in. From this reason, I am reverting WBT changes as well. They will be introduced in another PR. Removals for the follow up:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without having all the context, the changes look good, and I imagine tests will pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think instantiate_segmentation_rules_asset
should be deleted too.
I wonder if this will break any file-based SDK tests
|
||
}; | ||
if (WasmEnableThreads) { | ||
rh.dumpThreads = mono_wasm_dump_threads; | ||
rh.mono_wasm_print_thread_dump = () => tcwraps.mono_wasm_print_thread_dump(); | ||
} | ||
if (loaderHelpers.config.globalizationMode === GlobalizationMode.Hybrid) { | ||
rh.stringToUTF16 = stringToUTF16; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is any of the string functions now un-used ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instantiate_segmentation_rules_asset
is deleted from src/mono/browser/runtime/assets.ts
, I cannot find any other occurrence that is left, so I guess it's okay.
stringToUTF16
is used but it's taken from the main module. This one that is deleted in the quoted code is a forwarded method to hybrid globalization module. During removal of hybrid code, we also removed the hybrid module, that's why this line is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"file-based SDK tests" what is a file-based test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"file-based SDK tests" what is a file-based test?
More like this dotnet/sdk#45412
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but for .js file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ilonatommy you can run this command locally to get the new ICU:
|
|
@ilonatommy you need to run it in a checkout of this PR |
I got a result: |
Correct, you'd need to commit it like any other change. |
Connected PRs:
#110526
#110534
This is the last PR aiming at removing
HybridGlobalization
on WASM. Removals:Renames / preserved code:
We are leaving JS-based globalization method
GetLocaleInfo
to support APIs likeNativeName
andDisplayName
in the regular, ICU globalization mode. The code will be exported bysrc\mono\browser\runtime\globalization.ts
.locales-common.ts
->globalization-locale.ts
globalization-locale.ts
Closes #102373, #95795, #98483, #95921