Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] further improve HTTP cancelation #100029

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

pavelsavara
Copy link
Member

  • fix reason propagation in PromiseHolder
  • fix abort propagation in http_wasm_get_streamed_response_bytes
  • improve timing of EchoHandler "delay10sec"
  • improve test HttpClient_CancelInDifferentThread
  • cleanup

Fixes #98101

- fix abort propagation in http_wasm_get_streamed_response_bytes
- improve timing of EchoHandler "delay10sec"
- improve test HttpClient_CancelInDifferentThread
- cleanup
@pavelsavara pavelsavara marked this pull request as ready for review March 21, 2024 12:19
…ver/Handlers/EchoHandler.cs

Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara
Copy link
Member Author

/ba-g there is Log which is known issue #99961

@pavelsavara pavelsavara merged commit 1c73fa7 into dotnet:main Mar 21, 2024
96 of 98 checks passed
@pavelsavara pavelsavara deleted the browser_mt_cancelation3 branch March 21, 2024 15:47
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mt][browser] HttpClient_CancelInDifferentThread failing with operation cancelled
3 participants