Don't log error from background service if host is gracefully stopped while still starting #100032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… while still starting Fixes dotnet#98935
|
Tagging subscribers to this area: @dotnet/area-extensions-hosting |
dotnet-policy-service
bot
added
the
community-contribution
|
@dotnet-policy-service agree |
This was referenced Mar 21, 2024
steveharter
approved these changes
Mar 27, 2024
|
Thanks @ProsserCJ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98935
Description
Previous work supressed errors for canceled background services when the host stops gracefully, but did not do so unless the host had finished starting. This fix does so even if the host is still starting.
This change checks the ApplicationStopping CancellationToken on the ApplicationLifetime (which should be updated as soon as the stop is requested) instead of using the _stopCalled flag.
Testing
Added a xUnit test covering the reported scenario