Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GetFoldedArithOpResultHandleFlags #100060

Merged

Conversation

BruceForstall
Copy link
Member

For any constant arithmetic on a handle, lose the handle type: it's unreliable.

Eliminates problems seen in #100059

For any constant arithmetic on a handle, lose the handle type:
it's unreliable.

Eliminates problems seen in dotnet#100059
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 21, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@BruceForstall
Copy link
Member Author

/azp run runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

1 similar comment
@BruceForstall
Copy link
Member Author

/azp run runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@BruceForstall
Copy link
Member Author

Diffs - a few small code size improvements where it looks like we don't create new constants and instead re-use existing nearby constants.

@BruceForstall BruceForstall merged commit c1fc1ee into dotnet:main Mar 21, 2024
179 of 189 checks passed
@BruceForstall BruceForstall deleted the ForgetHandlesInVNFuncFolding branch March 21, 2024 16:50
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants