Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove more Helper Method Frames #100116

Merged
merged 7 commits into from
Mar 23, 2024
Merged

Remove more Helper Method Frames #100116

merged 7 commits into from
Mar 23, 2024

Conversation

AaronRobinsonMSFT
Copy link
Member

Converted COMCustomAttribute::ParseAttributeUsageAttribute() to C#.
Converted COMCustomAttribute::CreateCaObject() from FCall to QCall.
Converted COMCustomAttribute::GetPropertyOrFieldData() from FCall to QCall.

@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 9.0.0 milestone Mar 22, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@AaronRobinsonMSFT AaronRobinsonMSFT marked this pull request as ready for review March 22, 2024 03:49
@build-analysis build-analysis bot mentioned this pull request Mar 22, 2024
Closed
@build-analysis build-analysis bot mentioned this pull request Mar 22, 2024
Closed
jkotas
jkotas approved these changes Mar 23, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

src/coreclr/vm/customattribute.cpp Outdated Show resolved Hide resolved
src/coreclr/vm/customattribute.cpp Outdated Show resolved Hide resolved
src/coreclr/vm/customattribute.cpp Outdated Show resolved Hide resolved
src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs Show resolved Hide resolved
@build-analysis build-analysis bot mentioned this pull request Mar 23, 2024
Closed
@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 46870ff into dotnet:main Mar 23, 2024
92 checks passed
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the remove_more_helpers branch March 23, 2024 15:40
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huoyaoyuan huoyaoyuan huoyaoyuan left review comments

@jkotas jkotas jkotas approved these changes

@steveharter steveharter Awaiting requested review from steveharter

Assignees

@AaronRobinsonMSFT AaronRobinsonMSFT

Labels
area-VM-coreclr
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AaronRobinsonMSFT @huoyaoyuan @jkotas