-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reenable C4242 and C4244 warnings in libunwind #100241
Reenable C4242 and C4244 warnings in libunwind #100241
Conversation
Tagging subscribers to this area: @tommcdon |
Looks great! :) Few errors showing up in the CI:
When upstream PR is created, please include its reference in src/native/external/libunwind-version.txt in this PR's branch. |
This should also fix #100207. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@am11 if you could also take another pass at this, I would be most appreciative. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for wrapping this up! LGTM
@AaronRobinsonMSFT, looks good but can you please open a PR upstream and reference it in version file? We have been following that pattern for all similar PRs. |
Fixes #99471
Fixes #100207
Big thanks to @filipnavara for doing this.
Will create upstream (libunwind) patch after confirmation we are clean.