Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono][wasm] Force interpreter to initialize the pointers #100288

Merged
merged 13 commits into from
Mar 28, 2024
Merged

[mono][wasm] Force interpreter to initialize the pointers #100288

merged 13 commits into from
Mar 28, 2024

Conversation

mkhamoyan
Copy link
Contributor

Fixes #95087

@mkhamoyan mkhamoyan added the arch-wasm WebAssembly architecture label Mar 26, 2024
@mkhamoyan mkhamoyan self-assigned this Mar 26, 2024
lewing

This comment was marked as resolved.

Sign in to view

This was referenced Mar 26, 2024
Closed
Closed
@lewing
Copy link
Member

lewing commented Mar 26, 2024

This passes locally so let's get it asap once we have a test.

This was referenced Mar 27, 2024
Closed
Open
Closed
@build-analysis build-analysis bot mentioned this pull request Mar 28, 2024
Closed
@mkhamoyan mkhamoyan marked this pull request as ready for review March 28, 2024 11:59
maraf
maraf approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@mkhamoyan
Copy link
Contributor Author

/ba-g failures are not related.

@mkhamoyan mkhamoyan merged commit 1f00cda into dotnet:main Mar 28, 2024
76 of 79 checks passed
@mkhamoyan mkhamoyan deleted the 95087_interpreter_support branch March 28, 2024 17:49
@sbomer sbomer mentioned this pull request Mar 28, 2024
Open
@mkhamoyan mkhamoyan mentioned this pull request Apr 23, 2024
Open
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pavelsavara pavelsavara pavelsavara left review comments

@maraf maraf maraf approved these changes

@lewing lewing lewing approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

Assignees

@mkhamoyan mkhamoyan

Labels
arch-wasm WebAssembly architecture area-VM-meta-mono
Projects
None yet
Milestone
No milestone
4 participants
@mkhamoyan @lewing @pavelsavara @maraf