-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] emscripten bump 3.1.56 #100334
Merged
radekdoulik
merged 59 commits into
dotnet:main
from
radekdoulik:pr-wasm-emscripten-bump-3.1.56
Jul 15, 2024
Merged
[wasm] emscripten bump 3.1.56 #100334
Changes from all commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
e52f7df
[wasm] Bump emscripten to 3.1.56
radekdoulik a91ec44
Replace Module.asm with Module.wasmExports
radekdoulik d23f6fa
Updates for .native.worker.js -> mjs rename
radekdoulik 9848b92
Merge branch 'main' into pr-wasm-emscripten-bump-3.1.56
radekdoulik 50dfb72
Update deps
radekdoulik aca6c58
Add general testing feed
radekdoulik f229a30
Merge branch 'main' into pr-wasm-emscripten-bump-3.1.56
radekdoulik f917ea6
Update mode deps
radekdoulik a7c4e55
Update path
radekdoulik 0b030c1
Use current python packages for now, we don't have newer ones
radekdoulik 6a0057f
Keep using llvm 16 for runtime and aot compiler
radekdoulik 6cde92a
Merge branch 'main' into pr-wasm-emscripten-bump-3.1.56
radekdoulik 1721779
Add -Wno-pre-c11-compat only for browser
radekdoulik fe1e5c6
Temporarily disable version checks to get further
radekdoulik 3f8834f
Temporarily disable version checks to get further #2
radekdoulik 123767a
Disable -Wunused-command-line-argument
radekdoulik e3b1316
Update emsdk deps
radekdoulik 7d6edc3
Update icu dependency
radekdoulik 15bd585
Revert "Temporarily disable version checks to get further #2"
radekdoulik 92b4559
Revert "Temporarily disable version checks to get further"
radekdoulik d7b1d52
Fix emsdk check
radekdoulik 3593c41
Workaround wasm-opt crash
radekdoulik 4530edf
Workaround wasm-opt crash
radekdoulik 200cf3b
Workaround wasm-opt crash
radekdoulik 6e86cc3
Fix WBT test
radekdoulik 02fb272
Merge branch 'main' into pr-wasm-emscripten-bump-3.1.56
radekdoulik c313fa5
Feedback
radekdoulik 253ebf9
Merge branch 'main' into pr-wasm-emscripten-bump-3.1.56
lewing 0d7708b
Update ICU dependency
radekdoulik 8a12f44
Update emscripten deps
radekdoulik fc6ad97
Revert "Workaround wasm-opt crash"
radekdoulik 683bd51
Revert "Workaround wasm-opt crash"
radekdoulik b15fd5c
Revert "Workaround wasm-opt crash"
radekdoulik 9ae3c2f
Increase tests timeout
radekdoulik 60a4799
Show test progress
radekdoulik 4dadd6d
Merge branch 'main' into pr-wasm-emscripten-bump-3.1.56
radekdoulik 3bd6bfb
Increase MT library tests timeout
radekdoulik 16866a1
Disable WBT tests with SkiaSharp
radekdoulik d53aaa3
Increase helix tests timeout on browser
radekdoulik 6765913
Merge branch 'main' into pr-wasm-emscripten-bump-3.1.56
radekdoulik 4c69c36
Increase WBT timeout
radekdoulik c268a87
Increase initial heap sizes
radekdoulik d1d8619
Merge branch 'main' into pr-wasm-emscripten-bump-3.1.56
radekdoulik abe9b00
Fix mono_wasm_load_runtime cwrap signature
radekdoulik 63087a5
Merge branch 'main' into pr-wasm-emscripten-bump-3.1.56
radekdoulik d5a0bc4
Enable XunitShowProgress for threading tasks tests
radekdoulik 5d9a6d2
Try to reduce number of parallel AOT compilations
radekdoulik 8505fd5
Merge branch 'main' into pr-wasm-emscripten-bump-3.1.56
radekdoulik 3fe1e1f
Use new docker image for helix/windows tests
radekdoulik b2655bf
Revert "Try to reduce number of parallel AOT compilations"
radekdoulik ba1ad20
Merge branch 'main' into pr-wasm-emscripten-bump-3.1.56
pavelsavara 009e371
Reduce the timeouts
radekdoulik 9e0d5ce
Reduce intitial heap size
radekdoulik 061f2b5
Merge branch 'main' into pr-wasm-emscripten-bump-3.1.56
pavelsavara 8ed7bf9
use active issues for MT
pavelsavara d665bfa
Merge branch 'main' into pr-wasm-emscripten-bump-3.1.56
radekdoulik fdbb1f2
Remove testing channel from nuget config, update deps
radekdoulik ddc4698
Update emsdk and icu dependencies
radekdoulik e6426d2
Merge branch 'main' into pr-wasm-emscripten-bump-3.1.56
radekdoulik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
3.1.34 | ||
3.1.56 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,7 +45,7 @@ set(ignoreMeEmsdkPath "${EMSDK_PATH}") | |
|
||
if(CMAKE_BUILD_TYPE STREQUAL "Release") | ||
add_custom_command(TARGET dotnet.native | ||
POST_BUILD COMMAND ${EMSDK_PATH}/bin/wasm-opt --enable-exception-handling ${CONFIGURATION_WASM_OPT_FLAGS} --strip-dwarf ${NATIVE_BIN_DIR}/dotnet.native.wasm -o ${NATIVE_BIN_DIR}/dotnet.native.wasm | ||
POST_BUILD COMMAND ${EMSDK_PATH}/bin/wasm-opt --enable-exception-handling --enable-simd --enable-bulk-memory ${CONFIGURATION_WASM_OPT_FLAGS} --strip-dwarf ${NATIVE_BIN_DIR}/dotnet.native.wasm -o ${NATIVE_BIN_DIR}/dotnet.native.wasm | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe on different PR, but could we split dwarf into separate file instead of stripping it ? |
||
COMMENT "Stripping debug symbols from dotnet.native.wasm using wasm-opt") | ||
endif() | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
if (_nativeModuleLoaded) throw new Error("Native module already loaded"); | ||
_nativeModuleLoaded = true; | ||
createDotnetRuntime = Module = createDotnetRuntime(Module); | ||
createDotnetRuntime = Module = moduleArg(Module); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I filled #104418 I hope we can pinpoint more specific root cause with your
XunitShowProgress
here