-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit Accounting related changes #100380
Conversation
Tagging subscribers to this area: @dotnet/gc |
9beeb42
to
34c53c5
Compare
cc4c736
to
fcbcdc2
Compare
4d24a44
to
78d6849
Compare
78d6849
to
1a3ef3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than the one small comment, LGTM!
This change is tested with all these combinations: x86/x64 Bug #102585 is found, but it is unrelated to commit accounting. |
heap_segment
are moved across heaps duringchange_heap_count
, this change records them so thatcommitted_by_oh_per_heap
is still valid.committed_by
values regardless ofheap_hard_limit
, which will allow usrefresh_memory_limit
for segments.verify_regions
into_DEBUG
.release_segment
, heap_segment are released byvirtual_free
, we need to also decrement the committed counters when that happen.get_segment
, we accidentally usedmax_generation
asoh
for UOH segments, this change will make it use the rightoh
.grow_brick_card_table
, heap_segment are released byvirtual_free
, we need to also decrement the committed counters when that happen.... to be continued.