Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser][mt] Fix SignalRClientTests timeouts #100516

Closed
wants to merge 2 commits into from
Closed

[browser][mt] Fix SignalRClientTests timeouts #100516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89a0166
Test retries on CI.
ilonatommy Apr 2, 2024
ea03c34
Merge branch 'main' into signalRtest-add-retries
ilonatommy Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/SignalRClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ public async Task SignalRPassMessages(string config, string transport)

List<string> consoleOutput = new();
List<string> serverOutput = new();
bool shouldRetry = true;
int retryCount = 0;
int maxRetryCount = 3;

var result = await RunSdkStyleAppForBuild(new(
Configuration: config,
Expand All @@ -62,8 +65,32 @@ public async Task SignalRPassMessages(string config, string transport)
throw new Exception(msg.Text);
}

if (msg.Text.Contains("Starting the app"))
{
await Task.Delay(TimeSpan.FromMinutes(2)); // wait for 2 minutes for the test to start
if (shouldRetry)
{
if (retryCount < maxRetryCount)
{
retryCount++;
Console.WriteLine($"Starting the {retryCount} / {maxRetryCount} retry");
string currentUrl = page.Url;
await page.GotoAsync(currentUrl);
}
else
{
throw new Exception($"Max retries reached. Test failed.\n{_testOutput}");
}
}
}

if (msg.Text.Contains("Finished GetQueryParameters"))
{
// WASM got loaded, no more retries
shouldRetry = false;
// first click after render - make sure buttons are available
await SaveClickButtonAsync(page, "button#connectButton");
}

if (msg.Text.Contains("SignalR connected"))
await SaveClickButtonAsync(page, "button#subscribeButton");
Expand Down
1 change: 1 addition & 0 deletions src/mono/wasm/testassets/BlazorHostedApp/BlazorHosted.Client/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@
builder.RootComponents.Add<HeadOutlet>("head::after");
builder.Services.AddScoped(sp => new HttpClient { BaseAddress = new Uri(builder.HostEnvironment.BaseAddress) });

Helper.TestOutputWriteLine($"Starting the app");
await builder.Build().RunAsync().ConfigureAwait(false);