Remove distros versions calculation

[am11]

Remove distro version calculation for non-portable builds. The user can specify the desired value via --outputrid option (which is already used by source-build).

[am11]

@tmds, @elinor-fung, I was thinking something along these lines. It entails additional work such as:

• Add --outputrid required argument in dotnet/dotnet's build.sh: dotnet/dotnet@main...am11:dotnet:patch-2
• Sync https://github.com/dotnet/dotnet/blob/1550d92/Directory.Build.props#L50 with

  runtime/Directory.Build.props

  Line 251 in e8f163a

  <PropertyGroup Label="CalculateOutputRID">

• Upstream eng/common changes to dotnet/arcade repo.
• Add a comment in corehost normalize_linux_rid() "Non-Portable RID is frozen since .NET 8; this code need to stay for backward compatibility." something to that effect.

This way, distro maintainers will be free to use their preferred convention without needing to maintain those details in dotnet infra.

[tmds]

For non-portable Linux build, I think we should keep the logic that determines a rid based on /etc/os-release. This calculates a sensible value in a consistent way.
Maintainers that want something different can take control by specifying --output-rid

[am11]

For non-portable Linux build, I think we should keep the logic that determines a rid based on /etc/os-release. This calculates a sensible value in a consistent way. Maintainers that want something different can take control by specifying --output-rid

That will defeat its purpose. Previous discussion was to remove these cases dotnet/arcade#14595 (comment).

I think either we should make it consistently agnostic of distro info for all platforms, or keep maintaining it (and keep accepting Add support for ___ linux PRs). I am leaning towards former.

[tmds]

That will defeat its purpose. Previous discussion was to remove these cases dotnet/arcade#14595 (comment).

With that comment I meant: remove the special cases for specific Linux distros, like Oracle Linux.

I don't think we should force every distro maintainer to "choose" a rid and specify it using --output-rid when the script can calculate a sensible value to use.

[am11]

With that comment I meant: remove the special cases for specific Linux distros, like Oracle Linux.

Alright, you mean by using the same default for all distros: ${ID}.${VERSION} (and ${ID} when VERSION is empty), correct?

--output-rid

You named it --outputrid 58c3d52 😉

[tmds]

cc @dotnet/distro-maintainers

[am11]

@omajid, in case it wasn't obvious, this is dead code from VMR's perspective (TargetRid in dotnet/dotnet repo is always set which maps to --outputrid in this repo). Since .NET 8, runtime repo is pretty much agnostic of nonportable RIDs. This PR is a followup cleanup to avoid future "Add support for ___ linux" type of PRs.

[jkoritzinsky]

As there's a change for tizen, cc: @dotnet/samsung.

Other than that, the fact that the VMR already provides a more comprehensive explicit feature here and that you're the maintainer for the sunOS-derived RIDs, this looks good to me.

I'll approve, but I'll wait a few days to merge in case any of our stakeholders have an issue that they want to raise.

[clamp03]

Thank you.

[mthalman]

• Add --outputrid required argument in dotnet/dotnet's build.sh: dotnet/dotnet@main...am11:dotnet:patch-2

@am11 - It doesn't look like this has been applied yet. This should be applied to https://github.com/dotnet/sdk/blob/main/src/SourceBuild/content/build.sh. Note that this change has surfaced an issue in how we reference the produced output from the build: dotnet/sdk#40843. So once it's exposed as a build script parameter, we'd need to flow the desired RID into that from the build pipeline. I think this would only need to be done for Alpine as its version changes with each revision.