Delete strong name cruft #1006
Merged
Delete strong name cruft #1006
+260
−1,550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
commented
Dec 18, 2019
| @@ -226,11 +226,7 @@ DLLEXPORT ICorJitCompiler* __stdcall getJit() | |||
| // If you are using it more broadly in retail code, you would need to understand the | |||
| // performance implications of accessing TLS. | |||
|
|
|||
| #ifndef __GNUC__ | |||
There was a problem hiding this comment.
Ifdef cleanup that came along for the ride.
jkotas
commented
Dec 18, 2019
danmoseley
reviewed
Dec 18, 2019
The amount of strong name support that CoreCLR needs is very small (really just a method to convert public key to public key token). It is not worth it to build a separate .lib for just this single method. Fold the strong name APIs into metadata and change the API to return HRESULT.
elinor-fung
reviewed
Dec 18, 2019
|
Mostly unrelated, but have we recently gone through an exercise of dumping the functions the linker is dropping, and considering whether any represent code that can be deleted? I know at least some linkers will tell you what they dropped. I could imagine building for all targets, then finding the intersection. |
elinor-fung
approved these changes
Dec 18, 2019
nattress
approved these changes
Dec 18, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The amount of strong name support that CoreCLR needs is very small (really just a method to convert public key to public key token). It is not worth it to build a separate .lib for just this single method. Fold the strong name APIs into metadata and change the API to return HRESULT.