Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata for workload automation #100648

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

joeloff
Copy link
Member

@joeloff joeloff commented Apr 4, 2024

Description

To automate VSDROP insertions from staging builds, we need to include some additional metadata that is difficult to obtain from staging builds, like the assembly file version that is used when versioning drop components.

Testing

Manually verified metadata against internal builds. Cannot be fully tested until we have a fully staged build and all the automation pipelines completed.

@joeloff joeloff added the Servicing-consider Issue for next servicing release review label Apr 4, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 4, 2024
@ericstj
Copy link
Member

ericstj commented Apr 15, 2024

@joeloff were you planning to merge this before end of day?

@joeloff
Copy link
Member Author

joeloff commented Apr 15, 2024

@joeloff were you planning to merge this before end of day?

Hoping to so we could get the workload automation unblocked, but I'm not quite sure why all the library tests are failing as they should not be related to the workloads.

@directhex
Copy link
Contributor

@joeloff the libraries failures are known, and not your problem.

https://dev.azure.com/dnceng-public/public/_build/results?buildId=630659&view=logs&j=9a5515a2-33bf-5680-e294-03cf4426280b&t=dae9b252-1692-5386-8bf9-deb520e61356&l=1010 looks like a bigger concern though, that one is not known to the system

@joeloff
Copy link
Member Author

joeloff commented Apr 15, 2024

@joeloff the libraries failures are known, and not your problem.

https://dev.azure.com/dnceng-public/public/_build/results?buildId=630659&view=logs&j=9a5515a2-33bf-5680-e294-03cf4426280b&t=dae9b252-1692-5386-8bf9-deb520e61356&l=1010 looks like a bigger concern though, that one is not known to the system

This seems like the issue, though again, this change isn't calling the command that's missing. Is that coming from mono.proj?

emcmake' is not recognized as an internal or external command

Seems to be coming from

<_MonoCMakeConfigureCommand Condition="'$(TargetsBrowser)' == 'true' and '$(OS)' != 'Windows_NT'">bash -c 'source $(EMSDK_PATH)/emsdk_env.sh 2>&amp;1 &amp;&amp; emcmake $(_MonoCMakeConfigureCommand)'</_MonoCMakeConfigureCommand>

Feels like there's something missing from the image or environment.

@joeloff
Copy link
Member Author

joeloff commented Apr 15, 2024

@directhex
Copy link
Contributor

I think it's a flake earlier up the build:

Error: Downloading URL 'https://storage.googleapis.com/webassembly/emscripten-releases-builds/deps/node-v14.15.5-win-x64.zip': <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1007)>

So the emsdk install fails, and emcmake isn't present.

@directhex
Copy link
Contributor

i.e. your changes aren't to blame - it's an infra issue beyond our control. We probably want a "known issue" for this failure condition, though.

@lewing
Copy link
Member

lewing commented Apr 15, 2024

/ba-g failure is known and has since been fixed

@lewing lewing merged commit f62ab5a into dotnet:release/6.0-staging Apr 15, 2024
169 of 181 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Workloads Workloads like wasm-tools Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants