-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SSLKEYLOGFILE in Release builds #100665
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManickaP
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo few small comments. Thank you!
src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicRemoteExecutorTests.cs
Show resolved
Hide resolved
src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicRemoteExecutorTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicRemoteExecutorTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicRemoteExecutorTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
wfurt
reviewed
Apr 5, 2024
wfurt
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general.
3 tasks
wfurt
reviewed
Apr 9, 2024
CI Failures are unrelated |
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
* Allow SSLKEYLOGFILE functionality in Release builds * Unify SSLKEYLOGFILE logging, gate behind AppContextSwitch * Add more points where QUIC secrets are logged * Enable in Debug builds without appctx switch * Update src/libraries/System.Net.Quic/src/System.Net.Quic.csproj Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com> * Code review feedback * More code review changes * i����Adjust appctx switch name --------- Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37915.
This PR unifies existing SSLKEYLOGFILE exporting between SslStream and QuicConnection to use same shared code, and enables the feature in Release builds of libraries. This makes the feature available to consumers without needing to compile Debug builds of .NET Runtime.
Note that the SSLKEYLOGFILE feature is currently supported for:
*MsQuic is not yet officially supported on OSX, but once it is, no changes should be necessary from .NET side.
For security concerns, in addition to setting SSLKEYLOGFILE environment variable, setting
System.Net.EnableSslKeyLogging
AppContext switch totrue
is required. This can be done either via codeor via {project}.runtimeconfig.json
Debug runtime libraires (= local development builds of .NET Runtime) don't require the AppContext switch for the feature.