[browser] Fix debugger support in WasmAppBuilder #100675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
maraf
commented
Apr 5, 2024
•
maraf
commented
- Fix regression from [browser] Fix debugger support #97213 for WasmAppBuilder SDK (used by runtime and wasmconsole template)
- The same defaults were missing in this SDK
- Add the same WBT as for Wasm SDK
maraf
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing |
This was referenced Apr 5, 2024
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
…ortAppBuilder # Conflicts: # src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/BootJsonBuilderHelper.cs # src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/GenerateWasmBootJson.cs # src/tasks/WasmAppBuilder/WasmAppBuilder.cs
This was referenced May 16, 2024
maraf
force-pushed
the
BrowserDebuggerSupportAppBuilder
branch
from
998402d to
aa9e854
Compare
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ilonatommy
approved these changes
May 31, 2024
src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/DebugLevelTests.cs
Outdated
Show resolved
Hide resolved
This was referenced May 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.