Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing property to include native libraries for Apple mobile native linker #100689

Conversation

kotlarmilos
Copy link
Member

Description

The _targetArchitecture is not being set correctly, leading to missing native libraries for the native linker. This is a hotfix for the CI failures. The Native AOT pipeline for Apple mobile will be reviewed and improved in subsequent PRs.

Fixes #100632

@kotlarmilos kotlarmilos added this to the 9.0.0 milestone Apr 5, 2024
@kotlarmilos kotlarmilos requested a review from ivanpovazan April 5, 2024 16:40
@kotlarmilos kotlarmilos self-assigned this Apr 5, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

@kotlarmilos kotlarmilos requested a review from cshung April 5, 2024 16:42
Copy link
Member

@cshung cshung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@matouskozak
Copy link
Member

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@matouskozak matouskozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simulator-x64 NAOT runtime tests are building without errors now. good job!

@kotlarmilos kotlarmilos merged commit 9268c18 into dotnet:main Apr 8, 2024
102 of 105 checks passed
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants