Adds back Enum constraint to Enum.GetNames<TEnum>() #100844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
This comment was marked as resolved.
This comment was marked as resolved.
terrajobst
added
area-System.Runtime
and removed
new-api-needs-documentation
needs-area-label
|
When was this removed? Was that recently / accidentally as part of Jan's reformat of the ref? |
stephentoub
approved these changes
Apr 9, 2024
|
Yeah. #100843. |
|
I assume we double checked to ensure nothing else was accidentally changed? |
|
I did another pass of Jan's PR. I couldn't find any more diffs. I did one full pass of all the code, then another pass looking at all generic constraints. In general we can trust APICompat to keep us safe - but it has a gap here with generic constraints. |
|
Thanks |
|
What's the verdict on the test failures? They seem unrelated (timeout on the WASM test side). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially addresses #100843