Arm64: Add SVE feature detection for Windows #100937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunalspathak
added
arm-sve
|
@dotnet/arm64-contrib |
kunalspathak
changed the title
tannergooding
approved these changes
Apr 11, 2024
| @@ -458,6 +462,11 @@ int minipal_getcpufeatures(void) | |||
|
|
|||
| // TODO: IsProcessorFeaturePresent doesn't support LRCPC2 yet. | |||
|
|
|||
| if (IsProcessorFeaturePresent(PF_ARM_SVE_INSTRUCTIONS_AVAILABLE)) | |||
| { | |||
| result |= ARM64IntrinsicConstants_Sve; | |||
There was a problem hiding this comment.
Does this give us parity between Linux/Windows at this point or are there others that are still missing on Windows that Linux currently handles?
There was a problem hiding this comment.
ARM64IntrinsicConstants_Rcpc2 and ARM64IntrinsicConstants_Rdm are still missing and I didn't see their equivalent yet on windows side.
There was a problem hiding this comment.
There was a problem hiding this comment.
I don't see an entry of LRCPC2 in that. It just has LRCPC that is mapped to 45.
There was a problem hiding this comment.
Yes, it's not LRCPC2. Not a big deal though, it's just a minor optimization on top of RCPC1
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
* Add SVE feature detection for Windows * Move the PF_ARM_SVE_INSTRUCTIONS_AVAILABLE under HOST_WINDOWS
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.