Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove more helper frames #100939

Merged
merged 9 commits into from
Apr 21, 2024
Merged

Remove more helper frames #100939

merged 9 commits into from
Apr 21, 2024

Conversation

AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT commented Apr 11, 2024 •
edited
Loading

Remove Helper Method Frames from managedmdimport(.hpp|.cpp).

@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 9.0.0 milestone Apr 11, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@AaronRobinsonMSFT AaronRobinsonMSFT marked this pull request as ready for review April 12, 2024 20:02
@AaronRobinsonMSFT
Copy link
Member Author

/cc @jkotas @steveharter @buyaa-n @elinor-fung

jkotas
jkotas reviewed Apr 16, 2024
View reviewed changes
jkotas
jkotas approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AaronRobinsonMSFT @jkotas
Update src/coreclr/vm/managedmdimport.cpp
2496619 
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
This was referenced Apr 19, 2024
Open
Open
@am11 am11 mentioned this pull request Apr 20, 2024
Closed
@AaronRobinsonMSFT AaronRobinsonMSFT merged commit a3dc133 into dotnet:main Apr 21, 2024
92 checks passed
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the remove_more_helper_frames branch April 21, 2024 01:44
@AaronRobinsonMSFT AaronRobinsonMSFT mentioned this pull request Apr 21, 2024
Merged
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@AaronRobinsonMSFT @jkotas @matouskozak
Remove helper frames from MetadataImport class FCalls (dotnet#100939)
b000415 
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@am11 am11 am11 left review comments

@jkotas jkotas jkotas approved these changes

@teo-tsirpanis teo-tsirpanis teo-tsirpanis left review comments

Assignees

@AaronRobinsonMSFT AaronRobinsonMSFT

Labels
area-VM-coreclr
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AaronRobinsonMSFT @am11 @jkotas @teo-tsirpanis