Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cdac] Implement a JSON contract reader #100966

Merged
merged 18 commits into from
Apr 19, 2024
Merged

[cdac] Implement a JSON contract reader #100966

merged 18 commits into from
Apr 19, 2024

Commits on Apr 12, 2024

  1. WIP: compact descriptor format json parser

    @lambdageek
    lambdageek committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    eddd004 View commit details
    Browse the repository at this point in the history

  2. checkpoint: camelCase dict keys; compact fields

    @lambdageek
    lambdageek committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    10c58f5 View commit details
    Browse the repository at this point in the history

  3. more parsing

    @lambdageek
    lambdageek committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    6e583da View commit details
    Browse the repository at this point in the history

  4. Follow C# coding guidelines 

    Co-authored-by: Aaron Robinson <arobins@microsoft.com>
    @lambdageek @AaronRobinsonMSFT
    lambdageek and AaronRobinsonMSFT committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    a454c1e View commit details
    Browse the repository at this point in the history

  5. additional comments

    @lambdageek
    lambdageek committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    ce03508 View commit details
    Browse the repository at this point in the history

  6. better doc comments 

    Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
    @lambdageek @am11
    lambdageek and am11 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    28d7afd View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. suggestions from reviews; remove FieldDescriptor wrong conversion 

    we incorrectly allowed `[number]` as a field descriptor
conversion. that's not allowed.  removed it.
    @lambdageek
    lambdageek committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    15b4ecb View commit details
    Browse the repository at this point in the history

  2. Make test project like the nativeoat+linker tests 

    Dont' use libraries test infrastructure.  Just normal arcade xunit support.
    @lambdageek
    lambdageek committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    22867c1 View commit details
    Browse the repository at this point in the history

  3. add tools.cdacreadertests subset; add to CLR_Tools_Tests test leg

    @lambdageek
    lambdageek committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    28f5633 View commit details
    Browse the repository at this point in the history

  4. one more code review chang

    @lambdageek
    lambdageek committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    aa58b4b View commit details
    Browse the repository at this point in the history

  5. add tools.cdacreadertests for subset validation

    @lambdageek
    lambdageek committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    894c7ff View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Elinor Fung <elfung@microsoft.com>
    @lambdageek @elinor-fung
    lambdageek and elinor-fung committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    6f65672 View commit details
    Browse the repository at this point in the history

  2. reorder cases

    @lambdageek
    lambdageek committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    b0c34da View commit details
    Browse the repository at this point in the history

  3. no duplicate fields/sizes in types

    @lambdageek
    lambdageek committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    01e3fdd View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Merge remote-tracking branch 'origin/main' into cdac-parse-json

    @lambdageek
    lambdageek committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    dcdc95a View commit details
    Browse the repository at this point in the history

  2. wip

    @lambdageek
    lambdageek committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    f0f8ef1 View commit details
    Browse the repository at this point in the history

  3. Make all cdacreader.csproj ProjectReferences use the same AdditionalP… 

    …roperties

Since we set Configuration and RuntimeIdentifier, if we don't pass the
same AdditionalProperties in all ProjectReferences, we bad
project.assets.json files
    @lambdageek
    lambdageek committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    afdb85e View commit details
    Browse the repository at this point in the history

  4. Don't share the native compilation AdditionalProperties

    @lambdageek
    lambdageek committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    5d91235 View commit details
    Browse the repository at this point in the history