Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging] [mono][debugger] Search for seqpoints directly from jitinfo if it's not find on get_default_jit_mm #100978

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 12, 2024

Backport of #100841 to release/8.0-staging

/cc @thaystg

Customer Impact

  • Customer reported
  • Found internally

In AOTed apps running on ARM64 Breakpoints are not hit in classes containing static fields that are initialized inline
#100243

Regression

  • Yes
  • No

It works on .NET 7.0.

Testing

I manually tested after the fix.

Risk

Low, only trying to search for seqpoints in jit object of the method if it's not found in get_default_jit_mm.

Copy link
Contributor

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. we will take for consideration in 8.0.x. please get a code review

@thaystg thaystg requested a review from lambdageek April 12, 2024 18:16
@jeffschwMSFT jeffschwMSFT added the Servicing-approved Approved for servicing release label Apr 12, 2024
@jeffschwMSFT jeffschwMSFT added this to the 8.0.5 milestone Apr 12, 2024
@lewing lewing merged commit f9feb68 into release/8.0-staging Apr 13, 2024
107 of 111 checks passed
@lewing lewing deleted the backport/pr-100841-to-release/8.0-staging branch April 13, 2024 22:48
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Debugger-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants