Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] Fix Cannot redefine property: stack #101042

Merged
merged 1 commit into from
Apr 15, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/mono/browser/runtime/loader/exit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,13 @@ export function mono_exit (exit_code: number, reason?: any): void {

// force stack property to be generated before we shut down managed code, or create current stack if it doesn't exist
const stack = "" + (reason.stack || (new Error().stack));
Object.defineProperty(reason, "stack", {
get: () => stack
});
try {
Object.defineProperty(reason, "stack", {
get: () => stack
});
} catch (e) {
// ignore
}

// don't report this error twice
const alreadySilent = !!reason.silent;
Expand Down
Loading