Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update System.Threading.Channels dependency #101101

Closed
wants to merge 3 commits into from

Conversation

WeihanLi
Copy link
Contributor

@WeihanLi WeihanLi commented Apr 16, 2024

Remove System.Threading.Tasks.Extensions dependency since it's already a dependency of Microsoft.Bcl.AsyncInterfaces

relates to #94417

Remove System.Threading.Tasks.Extensions dependency since it's a dependency of Microsoft.Bcl.AsyncInterfaces
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 16, 2024
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@stephentoub
Copy link
Member

Remove System.Threading.Tasks.Extensions dependency since it's already a dependency of Microsoft.Bcl.AsyncInterfaces

Why is this beneficial?

@WeihanLi
Copy link
Contributor Author

WeihanLi commented May 15, 2024

Remove System.Threading.Tasks.Extensions dependency since it's already a dependency of Microsoft.Bcl.AsyncInterfaces

Why is this beneficial?

image
Currently, it would have two dependencies from the package dependencies(for netstandard2.0 and net462), when removed, it should be only one dependency for Microsoft.Bcl.AsyncInterfaces

From my limited knowledge(please help correct me if I'm wrong), think it would behave the same way whether the reference existed or not, so trying to remove the reference, make the dependency cleaner and we could keep the Microsoft.Bcl.AsyncInterfaces updated without considering the upgrade of System.Threading.Tasks.Extensions.

While if there are more benefits to having a reference for System.Threading.Tasks.Extensions feel free to close

@stephentoub
Copy link
Member

Thanks.

@ericstj, is this desirable?

@ericstj
Copy link
Member

ericstj commented May 15, 2024

No it's not desirable. There's nothing wrong with stating your dependencies. Being explicit is actually better since it insulates you from a breaking change if a transitive dependency were removed.

@ericstj ericstj closed this May 15, 2024
@WeihanLi WeihanLi deleted the patch-1 branch May 16, 2024 00:05
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Threading community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants