-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser][MT] stop doing grow(0) #101248
Closed
Closed
[browser][MT] stop doing grow(0) #101248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
WebAssembly architecture
area-VM-threading-mono
os-browser
Browser variant of arch-wasm
labels
Apr 18, 2024
Tagging subscribers to 'arch-wasm': @lewing |
This was referenced Apr 18, 2024
This is why we need
I will keep this PR until we could also test in on FF cc @kg @radekdoulik |
pavelsavara
added
the
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
label
Apr 19, 2024
# Conflicts: # src/mono/browser/runtime/cancelable-promise.ts # src/mono/browser/runtime/marshal.ts # src/mono/browser/runtime/memory.ts # src/mono/browser/runtime/scheduling.ts # src/mono/browser/runtime/web-socket.ts
This was referenced Apr 25, 2024
Closed
Closed
Closed
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
arch-wasm
WebAssembly architecture
area-VM-threading-mono
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
os-browser
Browser variant of arch-wasm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see what breaks