Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] UnsafeAccessor: Enable tests for extern static methods without type parameters #101265

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

fanyang-mono
Copy link
Member

Contributes to #99830

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 18, 2024
Copy link
Contributor

Tagging subscribers to this area: @steveisok, @lambdageek
See info in area-owners.md if you want to be subscribed.

@fanyang-mono fanyang-mono added area-VM-meta-mono and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners area-Codegen-meta-mono labels Apr 18, 2024
@fanyang-mono
Copy link
Member Author

All CI failures are known.

@@ -2322,7 +2322,7 @@ method_sig_from_accessor_sig (MonoMethodBuilder *mb, gboolean hasthis, MonoMetho
ret->hasthis = hasthis;
for (int i = 1; i < ret->param_count; i++)
ret->params [i - 1] = ret->params [i];
memset (&ret->params[ret->param_count - 1], 0, sizeof (MonoType)); // just in case
memset (&ret->params[ret->param_count - 1], 0, sizeof (MonoType*)); // just in case
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this in mind if we need to do a net8.0 backport of any unsafe accessor fixes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, make sense.

@fanyang-mono fanyang-mono merged commit ec0a1e7 into dotnet:main Apr 22, 2024
126 of 130 checks passed
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
… type parameters (dotnet#101265)

* Enable tests for methods without type parameters

* Enable more field tests

* Enable all field tests

* Fix the type to get size for
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants