[release/8.0-staging] [mono][interp] Resolve virtual method on delegates created by compiled code #101290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…d code Creating a delegate would normally end up calling into the runtime via ves_icall_mono_delegate_ctor. However, jit/aot backand have a fastpath where the delegate is not fully initialized (relying on the delegate trampoline to resolve the actual method to be called when the delegate is first called). Interp delegate initialization therefore doesn't take place. If this is the case and the delegate method is virtual, we would need to resolve it based on the target object.
github-actions
bot
requested review from
BrzVlad and
kotlarmilos
as code owners
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos |
|
@simonrozsival could you please fill in the PR description? |
BrzVlad
approved these changes
Apr 23, 2024
|
@vitek-karas the template was filled out and Vlad reviewed it. If this is ready, please send the email to Tactics requesting approval and add the |
simonrozsival
added
the
Servicing-consider
vitek-karas
added
Servicing-approved
|
Approved over email. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #101168 to release/8.0-staging
/cc @simonrozsival @BrzVlad
Customer Impact
This issue caused customer's MacCatalyst app to crash. Because of this issue, delegates are potentially broken when mixing aot and interpreted code. Delegates created in aot-code that contain a virtual method on a target object are not invoked properly in the interpreter because we don't resolve the virtual method on the object.
Regression
Testing
Manual testing. This change only affects calls from code that is compiled with Mono AOT and code that is using the Mono Interpreter. This is a configuration that is sometimes used in iOS and Mac Catalyst apps and it is hard to test with automated tests. The fix was verified in the context of a Mac Catalyst repro app (#101074).
Risk
Low