fix Alpine build break #101302
Merged
fix Alpine build break #101302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apline defines NULL as std::nullptr which is not comparable/assignable with intptr_t Fixes dotnet/source-build#4345
|
Tagging subscribers to this area: @tommcdon |
elinor-fung
approved these changes
Apr 19, 2024
2 tasks
akoeplinger
reviewed
Apr 20, 2024
| @@ -48,7 +48,7 @@ CDAC::CDAC(HMODULE module, uint64_t descriptorAddr, ICorDebugDataTarget* target) | |||
| { | |||
| if (m_module == NULL) | |||
| { | |||
| m_cdac_handle = NULL; | |||
| m_cdac_handle = 0; | |||
There was a problem hiding this comment.
looks like the approach in #100796 was to cast NULL to INT_PTR instead
There was a problem hiding this comment.
I think it's a style preference. in this case m_cdac_handle isn't a pointer (it happens to be a NativeAOT GCHandle), so (INT_PTR)NULL isn't really apropriate, either.
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
Apline defines NULL as std::nullptr which is not comparable/assignable with intptr_t Fixes dotnet/source-build#4345
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apline defines NULL as std::nullptr which is not comparable/assignable with intptr_t
Fixes dotnet/source-build#4345