Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedup UnboundedChannel and UnboundedPriorityChannel #101396

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

stephentoub
Copy link
Member

We can use generic specialization to avoid duplicating all the code for the different queue types. This should also make it much simpler to add other queue types in the future.

We can use generic specialization to avoid duplicating all the code for the different queue types. This should also make it much simpler to add other queue types in the future.
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-threading-channels
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I've left some comments but they were all subjective rename proposals, so feel free to ignore them or address after merging this PR before Preview 4 snap (solving the bug is more important ;) ).

@stephentoub stephentoub merged commit b4e0169 into dotnet:main Apr 23, 2024
81 of 87 checks passed
@stephentoub stephentoub deleted the dedupchannels branch April 23, 2024 13:11
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
* Dedup UnboundedChannel and UnboundedPriorityChannel

We can use generic specialization to avoid duplicating all the code for the different queue types. This should also make it much simpler to add other queue types in the future.

* Address PR feedback
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
* Dedup UnboundedChannel and UnboundedPriorityChannel

We can use generic specialization to avoid duplicating all the code for the different queue types. This should also make it much simpler to add other queue types in the future.

* Address PR feedback
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants