Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Do not use link flags for bitcode compilation #101397

Merged
merged 4 commits into from
Apr 23, 2024

Commits on Apr 22, 2024

  1. [wasm] Do not use link flags for bitcode compilation

    This avoids errors like:
    
        /root/helix/work/correlation/build/wasm-shared/WasmApp.Common.targets(832,5): error : emcc: warning: linker setting ignored during compilation: 'EXPORT_ES6' [-Wunused-command-line-argument] [/root/helix/work/workitem/e/publish/ProxyProjectForAOTOnHelix.proj]
        /root/helix/work/correlation/build/wasm-shared/WasmApp.Common.targets(832,5): error : emcc: warning: linker setting ignored during compilation: 'EXPORT_EXCEPTION_HANDLING_HELPERS' [-Wunused-command-line-argument] [/root/helix/work/workitem/e/publish/ProxyProjectForAOTOnHelix.proj]
    radekdoulik committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    5d7c0fc View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Rename _BitcodeLDFlags to _BitcodeCompileFlags

    Update the comment as well.
    
    _BitcodeLDFlags were used only for the BC compilation. This way
    we keep the possibility to add extra flags via EmccExtraBitcodeCompilationFlags and
    WasiClangExtraBitcodeCompileFlags.
    radekdoulik committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    d02db0d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ec768ed View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    45fdcf4 View commit details
    Browse the repository at this point in the history