Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read EnableWriteXorExecute from runtimeConfig #101490

Merged
merged 5 commits into from
Apr 29, 2024

Conversation

Quickern
Copy link
Contributor

There's OS with very strict environment that forbids env variables change in some cases. And W^X can be disabled.
Added option to runtime config.

I have some concerns about configuration option name. "System.Runtime.EnableWriteXorExecute" looks very similar to other config options.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 24, 2024
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@mangod9 mangod9 requested a review from janvorli April 24, 2024 15:33
@jkotas
Copy link
Member

jkotas commented Apr 24, 2024

Are we going to need to teach the compliance tools to check for this being disabled in the application config?

@mangod9
Copy link
Member

mangod9 commented Apr 24, 2024

yeah guess we will need to follow up.

@Quickern Quickern requested a review from mangod9 April 24, 2024 16:19
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli janvorli merged commit 901fd65 into dotnet:main Apr 29, 2024
87 checks passed
@Quickern
Copy link
Contributor Author

/backport to release/8.0-staging

Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/8875604396

Copy link
Contributor

@Quickern an error occurred while backporting to release/8.0-staging, please check the run log for details!

Error: @Quickern is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=Quickern

@Quickern
Copy link
Contributor Author

I am sorry about unnecessary command.
Any chances of backporting this PR to 8.0-staging?

@janvorli @mangod9

@mangod9
Copy link
Member

mangod9 commented Apr 29, 2024

Can you please provide a scenario/justification so we can determine feasibility to backport to 8. Thanks

matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
* Read System.Runtime.EnableWriteXorExecute from config.

* Fixed default value for W^X enabling option.

* Revert "Fixed default value for W^X enabling option."

This reverts commit b6857a1.

---------

Co-authored-by: Manish Godse <61718172+mangod9@users.noreply.github.com>
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
* Read System.Runtime.EnableWriteXorExecute from config.

* Fixed default value for W^X enabling option.

* Revert "Fixed default value for W^X enabling option."

This reverts commit b6857a1.

---------

Co-authored-by: Manish Godse <61718172+mangod9@users.noreply.github.com>
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
* Read System.Runtime.EnableWriteXorExecute from config.

* Fixed default value for W^X enabling option.

* Revert "Fixed default value for W^X enabling option."

This reverts commit b6857a1.

---------

Co-authored-by: Manish Godse <61718172+mangod9@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants