-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read EnableWriteXorExecute from runtimeConfig #101490
Conversation
Tagging subscribers to this area: @mangod9 |
Are we going to need to teach the compliance tools to check for this being disabled in the application config? |
yeah guess we will need to follow up. |
This reverts commit b6857a1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
/backport to release/8.0-staging |
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/8875604396 |
@Quickern an error occurred while backporting to release/8.0-staging, please check the run log for details! Error: @Quickern is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=Quickern |
Can you please provide a scenario/justification so we can determine feasibility to backport to 8. Thanks |
* Read System.Runtime.EnableWriteXorExecute from config. * Fixed default value for W^X enabling option. * Revert "Fixed default value for W^X enabling option." This reverts commit b6857a1. --------- Co-authored-by: Manish Godse <61718172+mangod9@users.noreply.github.com>
* Read System.Runtime.EnableWriteXorExecute from config. * Fixed default value for W^X enabling option. * Revert "Fixed default value for W^X enabling option." This reverts commit b6857a1. --------- Co-authored-by: Manish Godse <61718172+mangod9@users.noreply.github.com>
* Read System.Runtime.EnableWriteXorExecute from config. * Fixed default value for W^X enabling option. * Revert "Fixed default value for W^X enabling option." This reverts commit b6857a1. --------- Co-authored-by: Manish Godse <61718172+mangod9@users.noreply.github.com>
There's OS with very strict environment that forbids env variables change in some cases. And W^X can be disabled.
Added option to runtime config.
I have some concerns about configuration option name. "System.Runtime.EnableWriteXorExecute" looks very similar to other config options.