Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0-preview4] Restrict indentation size in JsonWriterOptions theories. #101525

Merged

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #101498 to release/9.0-preview4

/cc @carlossanlop @eiriktsarpalis

Customer Impact

  • Customer reported
  • Found internally

[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

[How was the fix verified? How was the issue missed previously? What tests were added?]

Risk

[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test only change, tell mode. Approved. cc @mmitche

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Apr 25, 2024
@carlossanlop carlossanlop added this to the 9.0.0 milestone Apr 25, 2024
@carlossanlop carlossanlop merged commit da4dd21 into release/9.0-preview4 Apr 25, 2024
79 of 89 checks passed
@carlossanlop carlossanlop deleted the backport/pr-101498-to-release/9.0-preview4 branch April 25, 2024 15:30
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Json Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants