Move timing out tests to Outerloop #101556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
eiriktsarpalis
commented
Apr 25, 2024
| @@ -3069,10 +3069,9 @@ public void WritingHugeBase64Bytes(JsonWriterOptions options) | |||
| } | |||
|
|
|||
| // https://github.com/dotnet/runtime/issues/30746 | |||
| [Theory] | |||
| [Theory, OuterLoop("Very long running test")] | |||
There was a problem hiding this comment.
This test to took 40 seconds to run on my machine, arguably this is too long even for outerloop. I think we could just reduce the amount of inputs being used by this theory.
There was a problem hiding this comment.
Thanks for removing the conditions for the outer loop attribute. It's also showing up in the output I shared for the issue this is fixing.
carlossanlop
approved these changes
Apr 25, 2024
This was referenced Apr 25, 2024
Closed
Closed
Closed
Closed
lewing
approved these changes
Apr 25, 2024
lewing
reviewed
Apr 25, 2024
| @@ -4422,7 +4421,7 @@ public void EscapeAsciiCharacters(JsonWriterOptions options) | |||
|
|
|||
| [Theory] | |||
| [MemberData(nameof(JsonOptions_TestData))] | |||
| [OuterLoop("Too slow", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser))] | |||
| [OuterLoop("Too slow", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime))] | |||
There was a problem hiding this comment.
These could probably be restricted to IsMonoInterpreter not all of mono but this is probably fine
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #101522