[wasm] Disable interp pgo recording by default since it adds startup overhead #101566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos |
This was referenced Apr 25, 2024
Closed
Closed
Closed
maraf
reviewed
Apr 26, 2024
Address PR feedback
kg
requested review from
ilonatommy,
lewing,
pavelsavara,
lambdageek and
steveisok
as code owners
steveisok
approved these changes
Apr 27, 2024
This was referenced Apr 27, 2024
maraf
approved these changes
Apr 27, 2024
maraf
reviewed
Apr 27, 2024
Comment on lines
158
to
+164
| interpreterPgo: value, | ||
| interpreterPgoSaveDelay: autoSaveDelay | ||
| }); | ||
| if (monoConfig.runtimeOptions) | ||
| monoConfig.runtimeOptions.push("--interp-pgo-recording"); | ||
| else | ||
| monoConfig.runtimeOptions = ["--interp-pgo-recording"]; |
There was a problem hiding this comment.
The idea around here is that deep_merge_config solves this type of conditional assignement
Suggested change
| interpreterPgo: value, | |
| interpreterPgoSaveDelay: autoSaveDelay | |
| }); | |
| if (monoConfig.runtimeOptions) | |
| monoConfig.runtimeOptions.push("--interp-pgo-recording"); | |
| else | |
| monoConfig.runtimeOptions = ["--interp-pgo-recording"]; | |
| interpreterPgo: value, | |
| interpreterPgoSaveDelay: autoSaveDelay, | |
| runtimeOptions: ["--interp-pgo-recording"] | |
| }); |
There was a problem hiding this comment.
runtime/src/mono/browser/runtime/loader/config.ts
Lines 36 to 37 in 09b983e
There was a problem hiding this comment.
I see, thanks. I'll make a follow-up PR to clean this up.
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
…overhead (dotnet#101566) * Disable interp pgo recording by default since it adds startup overhead * Make withRuntimeOptions not trample existing runtime options
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
…overhead (dotnet#101566) * Disable interp pgo recording by default since it adds startup overhead * Make withRuntimeOptions not trample existing runtime options
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During startup for interpreted blazor we seem to spend a small but notable amount of time in here even if interp PGO isn't actually enabled. It's possible to set runtime options at startup, so anyone who wants to use interp PGO can just change this option in their app config, I think.
Open as draft for now because I think this will make a WBT fail.