JIT: Remove HANDLER_ENTRY_MUST_BE_IN_HOT_SECTION #101611
Merged
+5
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
/azp run runtime-jit-experimental |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
Azure Pipelines successfully started running 1 pipeline(s). |
amanasifkhalid
commented
Apr 26, 2024
| // we assert that it is OK to create new blocks. | ||
| // | ||
| assert(fgPredsComputed); | ||
| assert(fgSafeBasicBlockCreation); |
There was a problem hiding this comment.
We previously needed to these transition blocks when splitting after a BBJ_COND. Since removing its implicit fallthrough behavior, we no longer create transition blocks here.
AndyAyersMS
approved these changes
Apr 26, 2024
|
Build failure in |
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Late follow-up to #71273. I noticed
fgRelocateEHRegionscurrently never tries to move handler regions (even if we aren't doing hot/cold splitting) becausefgDetermineFirstColdBlockmust keep handler entries hot, which is no longer true. I plan to enable that functionality in the next PR; for now, this cleans up all the dead code around HANDLER_ENTRY_MUST_BE_IN_HOT_SECTION. This should be a no-diff change.cc @dotnet/jit-contrib, @AndyAyersMS PTAL. Thanks!