Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Switch off HybridGlobalization lane on v8 on CI #101671

Merged
merged 5 commits into from
Apr 30, 2024
Merged

[wasm] Switch off HybridGlobalization lane on v8 on CI #101671

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7586fda
Stop testing on v8.
ilonatommy Apr 29, 2024
89699a5
Try to block by scenario,
ilonatommy Apr 29, 2024
b0fa36f
Limit scenarios.
ilonatommy Apr 29, 2024
38f64f7
Feedback
ilonatommy Apr 30, 2024
ec3b885
Revert "Feedback"
ilonatommy Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,6 @@ jobs:
isWasmOnlyBuild: ${{ parameters.isWasmOnlyBuild }}
alwaysRun: true
scenarios:
- WasmTestOnV8
- WasmTestOnChrome
- WasmTestOnFirefox
- WasmTestOnNodeJS
Expand All @@ -215,7 +214,6 @@ jobs:
isWasmOnlyBuild: ${{ parameters.isWasmOnlyBuild }}
alwaysRun: true
scenarios:
- WasmTestOnV8
- WasmTestOnChrome
- WasmTestOnNodeJS

Expand Down
8 changes: 8 additions & 0 deletions ...balization.Calendars.Tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,14 @@
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<TestRuntime>true</TestRuntime>
<HybridGlobalization>true</HybridGlobalization>
</PropertyGroup>
<PropertyGroup Condition="'$(TargetOS)' == 'browser'">
<!-- This doesn't run on V8 because https://github.com/dotnet/runtime/pull/101671 -->
<Scenario>WasmTestOnChrome</Scenario>
<TestArchiveTestsRoot>$(TestArchiveRoot)browserornodejs/</TestArchiveTestsRoot>
<TestArchiveTestsDir>$(TestArchiveTestsRoot)$(OSPlatformConfig)/</TestArchiveTestsDir>
<DefineConstants>$(DefineConstants);TARGET_BROWSER</DefineConstants>
<XunitShowProgress>true</XunitShowProgress>
</PropertyGroup>
<ItemGroup>
<Compile Include="..\System\Globalization\CalendarTestBase.cs" />
Expand Down
8 changes: 8 additions & 0 deletions ...ime/tests/System.Globalization.Tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@
<IncludeRemoteExecutor>true</IncludeRemoteExecutor>
<HybridGlobalization>true</HybridGlobalization>
</PropertyGroup>
<PropertyGroup Condition="'$(TargetOS)' == 'browser'">
<!-- This doesn't run on V8 because https://github.com/dotnet/runtime/pull/101671 -->
<Scenario>WasmTestOnChrome</Scenario>
<TestArchiveTestsRoot>$(TestArchiveRoot)browserornodejs/</TestArchiveTestsRoot>
<TestArchiveTestsDir>$(TestArchiveTestsRoot)$(OSPlatformConfig)/</TestArchiveTestsDir>
<DefineConstants>$(DefineConstants);TARGET_BROWSER</DefineConstants>
<XunitShowProgress>true</XunitShowProgress>
ilonatommy marked this conversation as resolved.
Show resolved Hide resolved
</PropertyGroup>
<ItemGroup>
<Compile Include="..\CompareInfo\CompareInfoTestsBase.cs" />
<Compile Include="..\System\Globalization\TextInfoTests.cs" />
Expand Down
Loading