Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Test RPO-based layout in libraries-pgo #101924

Merged
merged 3 commits into from
May 6, 2024
Merged

JIT: Test RPO-based layout in libraries-pgo #101924

merged 3 commits into from
May 6, 2024

Conversation

amanasifkhalid
Copy link
Member

Follow-up to #101851. @AndyAyersMS PTAL, thank you!

@amanasifkhalid
Copy link
Member Author

/azp run runtime-coreclr libraries-pgo

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@amanasifkhalid
Copy link
Member Author

I'm not expecting libraries-pgo to be green at the moment -- just want to verify the config is being set in the Helix logs.

@amanasifkhalid amanasifkhalid added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed area-Infrastructure-coreclr labels May 6, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request May 6, 2024
Closed
@amanasifkhalid
Copy link
Member Author

libraries-pgo is blocked by another issue, but I can see the new block layout is running based on the DOTNET_ env vars being set: log.

AndyAyersMS
AndyAyersMS approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest leaving win arm64 off for now...

eng/pipelines/coreclr/libraries-pgo.yml Outdated
@@ -37,6 +37,7 @@ extends:
extraHelixArguments: /maxcpucount:10
scenarios:
- defaultpgo
- jitrpolayout
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't historically stressed Windows arm64 since we've been short on CI resources, and codegen is similar to Linux arm64. So perhaps leave this part out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing.

@amanasifkhalid amanasifkhalid merged commit 91b32f6 into dotnet:main May 6, 2024
9 checks passed
@amanasifkhalid amanasifkhalid deleted the libraries-pgo-layout branch May 6, 2024 19:04
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
@amanasifkhalid @michaelgsharp
JIT: Test RPO-based layout in libraries-pgo (dotnet#101924)
575604f
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@amanasifkhalid @Ruihan-Yin
JIT: Test RPO-based layout in libraries-pgo (dotnet#101924)
2840a92
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees

@amanasifkhalid amanasifkhalid

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amanasifkhalid @AndyAyersMS