Fix arm64 callee saved register set #101971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I've made a change to optimize the collided exception handling by copying the stack frame iterator state, I've somehow missed adding two callee saved registers, x27 and x28 to a list of callee saved registers and that caused them to not to be copied during the state copying. It has caused failures in one of the coreclr tests when running with specific JIT stress settings. Close dotnet#100476
jkotas
approved these changes
May 7, 2024
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
When I've made a change to optimize the collided exception handling by copying the stack frame iterator state, I've somehow missed adding two callee saved registers, x27 and x28 to a list of callee saved registers and that caused them to not to be copied during the state copying. It has caused failures in one of the coreclr tests when running with specific JIT stress settings. Close dotnet#100476
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
When I've made a change to optimize the collided exception handling by copying the stack frame iterator state, I've somehow missed adding two callee saved registers, x27 and x28 to a list of callee saved registers and that caused them to not to be copied during the state copying. It has caused failures in one of the coreclr tests when running with specific JIT stress settings. Close dotnet#100476
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I've made a change to optimize the collided exception handling by copying the stack frame iterator state, I've somehow missed adding two callee saved registers, x27 and x28 to a list of callee saved registers and that caused them to not to be copied during the state copying.
It has caused failures in one of the coreclr tests when running with specific JIT stress settings.
Close #100476