Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small followup to Use QueueUserAPC2 for EE suspension on CoreCLR win-arm64 #102021

Merged
merged 1 commit into from
May 8, 2024

Conversation

VSadov
Copy link
Member

@VSadov VSadov commented May 8, 2024

Re: #101891

RtlGetReturnAddressHijackTarget needs to be invoked. It is not the hijack address, it is the provider of the address.

Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, I have missed that

@VSadov
Copy link
Member Author

VSadov commented May 8, 2024

I missed that too. Merged, and then realized we skipped an indirection.

@VSadov
Copy link
Member Author

VSadov commented May 8, 2024

It would have failed in a CET-enabled run.

@mangod9
Copy link
Member

mangod9 commented May 8, 2024

It would have failed in a CET-enabled run.

we do have a CET enabled pipeline, but don't run it on a regular basis. @eduardo-vp, perhaps we should look into running it as extra-platforms suite.

@VSadov
Copy link
Member Author

VSadov commented May 8, 2024

we do have a CET enabled pipeline, but don't run it on a regular basis.

I think running once in a while may be sufficient. This is not something that is frequently touched.

@VSadov VSadov merged commit 214ea9c into dotnet:main May 8, 2024
87 of 89 checks passed
@VSadov VSadov deleted the apc2arm2 branch May 8, 2024 21:48
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants