Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SPMI collection script for ASP.NET #102025

Merged
merged 1 commit into from
May 8, 2024
Merged

Update SPMI collection script for ASP.NET #102025

merged 1 commit into from
May 8, 2024

Conversation

AndyAyersMS
Copy link
Member

  • Add some new scenarios.
  • Revise configs we use for collections
  • Use .Net 8 for crank.
  • Use temp dir that is not under the repo root for .NET install

@AndyAyersMS
Update SPMI collection script for ASP.NET
dda6c8d 
* Add some new scenarios.
* Revise configs we use for collections
* Use .Net 8 for crank.
* Use temp dir that is not under the repo root for .NET install
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 8, 2024
@AndyAyersMS
Copy link
Member Author

@EgorBo PTAL
cc @dotnet/jit-contrib

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

EgorBo
EgorBo approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New scenarios, yay!

This was referenced May 8, 2024
Closed
Closed
@AndyAyersMS AndyAyersMS merged commit c5301c4 into dotnet:main May 8, 2024
84 of 87 checks passed
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@AndyAyersMS @Ruihan-Yin
Update SPMI collection script for ASP.NET (dotnet#102025)
77efbc4 
* Add some new scenarios.
* Revise configs we use for collections
* Use .Net 8 for crank.
* Use temp dir that is not under the repo root for .NET install
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EgorBo EgorBo EgorBo approved these changes

Assignees

@AndyAyersMS AndyAyersMS

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndyAyersMS @EgorBo