Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arm64/Sve: Implement some more Math APIs #102170

Merged
merged 18 commits into from
May 14, 2024
Merged

Arm64/Sve: Implement some more Math APIs #102170

merged 18 commits into from
May 14, 2024

Conversation

kunalspathak
Copy link
Member

Implementation of following Math APIs:

  • AbsoluteDifference
  • AddSaturate
  • SubractSaturate
  • MultiplyExtended
  • Negate

All tests passing: https://gist.github.com/kunalspathak/29751d636f0ee457bc82396371f09244

Contributes to #99957

@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@kunalspathak kunalspathak requested a review from TIHan May 13, 2024 19:55
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

@kunalspathak kunalspathak mentioned this pull request May 13, 2024
Closed
@kunalspathak
Copy link
Member Author

@dotnet/arm64-contrib

TIHan
TIHan approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@TIHan TIHan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunalspathak
Copy link
Member Author

@TIHan - In this one, earlier, I pushed DotProduct APIs, without tests, but adding tests will take some time, so I have reverted the API and changes in hwintrinsiclistarm64sve.h for DotProduct*

@kunalspathak kunalspathak added the arm-sve Work related to arm64 SVE/SVE2 support label May 14, 2024
@build-analysis build-analysis bot mentioned this pull request May 14, 2024
Open
@build-analysis build-analysis bot mentioned this pull request May 14, 2024
Open
3 tasks
@kunalspathak kunalspathak merged commit 8c1e166 into dotnet:main May 14, 2024
165 of 167 checks passed
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@kunalspathak @Ruihan-Yin
Arm64/Sve: Implement some more Math APIs (dotnet#102170)
fb5a18a 
* Add AbsoluteDifference() API

* Map API to instruction

* add test cases

* Add AddSaturate() API

* Map API to instruction

* Add test case

* Add MultiplyExtend() API

* Map API to instruction

* Add test case

* Add Negate() and SubtractSaturate() APIs

* Map API to instruction

* Add test cases

* Fix AbsoluteDifference() tests

* Add DotProduct() and DotProductBySelectedScalar() APIs

* remove trailing space

* Map API to instruction

* Revert "Add DotProduct() and DotProductBySelectedScalar() APIs"

This reverts commit be2b75f.

* Revert "Map API to instruction"

This reverts commit 55d3e4e.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TIHan TIHan TIHan approved these changes

Assignees

@kunalspathak kunalspathak

Labels
area-System.Runtime.Intrinsics arm-sve Work related to arm64 SVE/SVE2 support new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunalspathak @TIHan