-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite the corehost CMake system to be more "Modern CMake"y and less MSBuild-y #102475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup hostcommon Make hostmisc an interface target instead of an include.
…to an object library.
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
jkoritzinsky
commented
May 22, 2024
elinor-fung
reviewed
Jun 1, 2024
elinor-fung
approved these changes
Jun 4, 2024
Co-authored-by: Elinor Fung <elfung@microsoft.com>
This was referenced Jun 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configure_file
instead of stringly-defined macros.include(foo.cmake)
This moves our CMake for the hosts build to be more similar to the rest of the build and more similar to CMake documentation you'll find online. This also removes quite a bit of duplicate/unnecessary CMake for some targets that was applied more widely than necessary.