Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] fix marshaling reject(null) #102549

Merged
merged 1 commit into from
May 22, 2024
Merged

[browser] fix marshaling reject(null) #102549

merged 1 commit into from
May 22, 2024

Conversation

pavelsavara
Copy link
Member

fixes #102339

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels May 22, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone May 22, 2024
@pavelsavara pavelsavara requested a review from maraf May 22, 2024 09:23
@pavelsavara pavelsavara self-assigned this May 22, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara pavelsavara marked this pull request as ready for review May 22, 2024 12:32
@pavelsavara pavelsavara requested a review from lewing as a code owner May 22, 2024 12:32
@pavelsavara
Copy link
Member Author

CI fails are #101930 and #102559

@build-analysis build-analysis bot mentioned this pull request May 22, 2024
Closed
@pavelsavara
Copy link
Member Author

/ba-g CI fails are #101930 and #102559

@pavelsavara pavelsavara merged commit 994a410 into dotnet:main May 22, 2024
34 of 36 checks passed
@pavelsavara pavelsavara deleted the browser_fix_null_reject branch May 22, 2024 13:11
@build-analysis build-analysis bot mentioned this pull request May 28, 2024
Closed
steveharter pushed a commit to steveharter/runtime that referenced this pull request May 28, 2024
@pavelsavara @steveharter
[browser] fix marshaling reject(null) (dotnet#102549)
3456bac
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@pavelsavara @Ruihan-Yin
[browser] fix marshaling reject(null) (dotnet#102549)
91fc13c
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

JSImport returning Promise that signals reject
2 participants
@pavelsavara @maraf