Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging] Backport 1ES templates #102681

Merged

Conversation

eduardo-vp
Copy link
Member

@eduardo-vp eduardo-vp commented May 25, 2024

This PR mainly backports #99433 (the 1ES templates).

The changes that were needed with this PR were cherry-picked for clarity. Also, as originally the maximum YAML size was exceeded in the runtime pipeline, the linux_x86, tizen_armel, and freebsd_x64 jobs were moved to the global-build pipeline.

Official build link (0f15d9e): https://dev.azure.com/dnceng/internal/_build/results?buildId=2462127&view=results

Cc @jkoritzinsky @agocke @amanasifkhalid

kotlarmilos and others added 9 commits May 24, 2024 17:35
…mage (dotnet#91019)

* Use host rootfs when TARGET_BUILD_ARCH matches
* Start moving over to official templates

* Parameterize runtime-inner-loop

* Use default false for isOfficialBuild in pipeline-with-resources

* Respond to PR comments

* Code review comments

* Use default template args
Import pool-providers in common variables. This should allow all stages access to the pool provider variables.
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 25, 2024
@eduardo-vp eduardo-vp added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 25, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@eduardo-vp eduardo-vp force-pushed the backport-1es-templates branch from 94793ad to 0f15d9e Compare May 28, 2024 23:06
@eduardo-vp
Copy link
Member Author

eduardo-vp commented May 28, 2024

@eduardo-vp eduardo-vp marked this pull request as ready for review May 29, 2024 07:53
@eduardo-vp eduardo-vp requested a review from marek-safar as a code owner May 29, 2024 07:53
@eduardo-vp eduardo-vp requested review from jkoritzinsky and agocke May 29, 2024 07:55
@eduardo-vp eduardo-vp added the Servicing-consider Issue for next servicing release review label May 29, 2024
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we can consider this as a tell mode change

cc @carlossanlop

@eduardo-vp eduardo-vp added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels May 29, 2024
@eduardo-vp eduardo-vp merged commit 32400f6 into dotnet:release/8.0-staging May 29, 2024
179 of 183 checks passed
amanasifkhalid added a commit that referenced this pull request Jun 11, 2024
This introduces new templates from #75473 needed to switch over the .NET 6 servicing branch to 1ES templates. Once this is merged, #102681 (along with some pool provider updates) should be all we need to switch release/6.0-staging over to 1ES templates.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants