-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ILLink: Sweep .override for interface method if the .interfaceImpl is removed #102857
Merged
Commits on May 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e365855 - Browse repository at this point
Copy the full SHA e365855View commit details
Commits on May 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7ffea50 - Browse repository at this point
Copy the full SHA 7ffea50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 157077c - Browse repository at this point
Copy the full SHA 157077cView commit details -
- inherited interface methods with overrides - instance methods on classes with .overrides
Configuration menu - View commit details
-
Copy full SHA for 4cd64ba - Browse repository at this point
Copy the full SHA 4cd64baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 564e231 - Browse repository at this point
Copy the full SHA 564e231View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1dc3410 - Browse repository at this point
Copy the full SHA 1dc3410View commit details
Commits on May 31, 2024
-
Mark the correct ifaceImpl, add tests
In MarkMethod, we mark the interfaceImpl that has the same type definition. If there are multiple implementations of a generic interface, each with different type parameters, we would only mark the first such interface. It just so happened that we never hit any issues because elsewhere we would keep the interface implementations since the interface definition was marked and the type was 'relevant to variant casting'. Adds tests for instance interface methods with .overrides in the public implementations. It doesn't seems possible to create a scenario where an instance method could be marked without the declaring type being marked 'relevant to variant casting' and all the interfaces being marked. Also, all methods pointed to by a .override is marked by ProcessMethod, so there isn't a scenario that would have dangling references in the .override.
Configuration menu - View commit details
-
Copy full SHA for 69c16ac - Browse repository at this point
Copy the full SHA 69c16acView commit details -
Configuration menu - View commit details
-
Copy full SHA for c4373c2 - Browse repository at this point
Copy the full SHA c4373c2View commit details
Commits on Jun 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 14dec4a - Browse repository at this point
Copy the full SHA 14dec4aView commit details
Commits on Jun 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1d4dc25 - Browse repository at this point
Copy the full SHA 1d4dc25View commit details
Commits on Jun 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c0761e3 - Browse repository at this point
Copy the full SHA c0761e3View commit details
Commits on Jun 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dd1578f - Browse repository at this point
Copy the full SHA dd1578fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.