Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't needlessly track the method handle for hwintrinsics when optimizations are disabled #102973

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

tannergooding
Copy link
Member

This should fix the minopts pessimization from #102827

There is still opportunity to improve the codegen further for fullopts, when it does need to stay a call, but that's less common and so less meaningful to fix.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 2, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@tannergooding
Copy link
Member Author

CC. @dotnet/jit-contrib

@TIHan TIHan merged commit 838bc26 into dotnet:main Jun 3, 2024
114 checks passed
@tannergooding tannergooding deleted the rationalize-hwintrinsic branch June 3, 2024 02:37
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants