Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce IBufferedLogger #103138

Merged
merged 7 commits into from
Jul 18, 2024
Merged

Introduce IBufferedLogger #103138

merged 7 commits into from
Jul 18, 2024

Conversation

geeknoid
Copy link
Member

@geeknoid geeknoid commented Jun 6, 2024 •
edited by tarekgh
Loading

Fixes #104129

@geeknoid geeknoid requested a review from tarekgh June 6, 2024 19:21
@geeknoid geeknoid requested a review from noahfalk June 6, 2024 19:24
@tarekgh tarekgh marked this pull request as draft June 6, 2024 20:08
@tarekgh
Copy link
Member

tarekgh commented Jun 6, 2024

@geeknoid LGTM. Thanks for getting this that fast. I left a minor comment there.

@noahfalk @samsp-msft any feedback?

@build-analysis build-analysis bot mentioned this pull request Jun 6, 2024
Open
@noahfalk
Copy link
Member

noahfalk commented Jun 7, 2024 •
edited
Loading

@noahfalk @samsp-msft any feedback?

I think we should do the transform you suggested so that we can extend this in the future if needed, but otherwise LGTM!

EDIT: We also need to figure out what we're doing with EventSourceLoggerProvider and OpenTelemetry. At minimum we should make sure OTel folks are on-board with the design and its implications for their logger prior to taking this for review.

@tarekgh
Copy link
Member

tarekgh commented Jun 7, 2024 •
edited
Loading

At minimum we should make sure OTel folks are on-board with the design and its implications for their logger prior to taking this for review.

@CodeBlanch was in the meeting. Will be good to understand the plan for any OTel logger for that though.

@samsp-msft
Copy link
Member

samsp-msft commented Jun 7, 2024 •
edited
Loading

@kalyanaj for FYI,
and open-telemetry/opentelemetry-specification#4044 for this group

@geeknoid geeknoid changed the title Introduce IBufferedLogRecordMetadata Introduce IBufferedLogRecord Jun 7, 2024
This was referenced Jun 10, 2024
Closed
Closed
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Jul 17, 2024
Open
3 tasks
geeknoid and others added 3 commits July 16, 2024 19:25
This was referenced Jul 18, 2024
Closed
Open
Open
Closed
@tarekgh tarekgh merged commit 223249f into dotnet:main Jul 18, 2024
75 of 83 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samsp-msft samsp-msft samsp-msft left review comments

@CodeBlanch CodeBlanch CodeBlanch left review comments

@xakep139 xakep139 xakep139 left review comments

@noahfalk noahfalk noahfalk approved these changes

@ilmax ilmax ilmax left review comments

@stephentoub stephentoub stephentoub left review comments

@tarekgh tarekgh tarekgh approved these changes

Assignees

@geeknoid geeknoid

Labels
area-Extensions-Logging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Introducing Log buffering abstraction
8 participants
@geeknoid @tarekgh @noahfalk @samsp-msft @stephentoub @ilmax @xakep139 @CodeBlanch