Add native ARM64 popcount for sizeof(T) above 1 to TensorPrimitives #103214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I validated that the codegen before and after the change for
sizeof(T) is 1
inInvokeSpanIntoSpan.Vectorized128
is identical so whatever difference there is, it is likely the noise (from non-temporal stores? I found the numbers unstable even at 256KiB of data).For
sizeof(T) is 8
I also tested Vector128 into Vector64x2 withvaddvq_u32
and back into V128 but it was slower than continuing to bruteforce.Environment:
Benchmark:
Current:
PR: