Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make System.Formats.Nrbf public #103232

Merged
merged 23 commits into from
Jun 14, 2024
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
8a396bb
apply the new library name: System.Formats.Nrbf
adamsitnik Jun 10, 2024
b49c824
rename the types and methods, make them public:
adamsitnik Jun 10, 2024
8ed896f
introduce non-generic PrimitiveTypeRecord, use it where it simplifies…
adamsitnik Jun 10, 2024
380b82e
remove ClassRecord.GetArrayOfPrimitiveType, add GetArrayRecord
adamsitnik Jun 10, 2024
0edfa3c
introduce SerializationRecordId, use it
adamsitnik Jun 10, 2024
f205fa9
make BinaryArrayType internal, add ArrayRecord.IsJagged, remove suppo…
adamsitnik Jun 10, 2024
43336ed
fix the build
adamsitnik Jun 11, 2024
e703c6b
TypeName matching changes:
adamsitnik Jun 11, 2024
7bd4b27
rename RecordType to SerializationRecordType, remove the byte size co…
adamsitnik Jun 11, 2024
a171648
add ref project
adamsitnik Jun 11, 2024
cd54d66
fix the build
adamsitnik Jun 12, 2024
daa7431
remove the need of having a separate stack of ids that are being pars…
adamsitnik Jun 12, 2024
dedcf0c
Apply suggestions from code review
adamsitnik Jun 12, 2024
e0ad582
remove special casing of TimeSpan that seems to be missing [TypeForwa…
adamsitnik Jun 12, 2024
0664932
type name matching: take generic type definition into account
adamsitnik Jun 12, 2024
3673b4f
Apply suggestions from code review
adamsitnik Jun 13, 2024
7352704
address code review feedback
adamsitnik Jun 13, 2024
5c3b266
Merge remote-tracking branch 'upstream/main' into nrbfPublic
adamsitnik Jun 13, 2024
9fbf59c
try to solve the pre-built error about System.ValueTuple by removing …
adamsitnik Jun 13, 2024
39832eb
increase the margin of error (this test needs to ensure 2GB is not be…
adamsitnik Jun 13, 2024
a151e6e
Apply suggestions from code review
adamsitnik Jun 14, 2024
729a61f
Apply suggestions from code review
adamsitnik Jun 14, 2024
770761d
add missing xml docs
adamsitnik Jun 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
increase the margin of error (this test needs to ensure 2GB is not be…
…ing allocated so we don't need to be very precise)
adamsitnik committed Jun 13, 2024

Unverified

This user has not yet uploaded their public signing key.
commit 39832eb58d7fe01ea758543cc41f514a2fa5c8df
2 changes: 1 addition & 1 deletion src/libraries/System.Formats.Nrbf/tests/AttackTests.cs
Original file line number Diff line number Diff line change
@@ -136,7 +136,7 @@ public void ArraysOfStringsAreNotBeingPreAllocated()

long after = GetAllocatedByteCount();

Assert.InRange(after, before, before + 1024);
Assert.InRange(after, before, before + 5000);
Assert.Equal(SerializationRecordType.ArraySingleString, serializationRecord.RecordType);
}