-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QUIC] Add platform guard to IsSupported
#103342
Conversation
Note regarding the
|
Note regarding the
|
Tagging subscribers to this area: @dotnet/ncl |
1ffd525
to
3e7cc3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably no need to add the attributes into generated files (QuicConnection.Unsupported.cs
, QuicListener.Unsupported.cs
), anyway if/when they regenerated the attributes will not be there.
They're not generated though, their content is on PNSE exclusion list and these sources are used instead. |
/ba-g wasm failure reported here: #103623 |
This should make the
IsSupported
properties not trigger the compiler warning about using unsupported API, in other words avoiding this:for a simple:
We might even try if we could get away with using the
QuicConnection.IsSupported
as a trimming guard (instead ofIsHttp3Supported()
) in HTTP code.EDIT: Analyzer is in main.
PR as a draft for now since it depends on dotnet/roslyn-analyzers#7326